[LinuxPPS] bug in kernel config

[Rodolfo Giometti]

On Wed, Feb 07, 2007 at 08:58:14AM -0600, Jon Schewe wrote:

> Some help lines might be good.  That or can you put a warning in the
> menu that displays when serial support is not a module, but PPS support
> is?  Like right now when you add PPS support directly into the kernel
> the 8250 option shows up.  If you could make it such that when one
> selects PPS as a module and serial support is not a module then an
> option appears under PPS support that says something like "warning PPS
> will not work without serial support, either compile serial support as a
> module or compile PPS support directly into the kernel".

Please, try the attached patch.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127
-------------- next part --------------
diff --git a/drivers/pps/clients/Kconfig b/drivers/pps/clients/Kconfig
index 736b20e..4214b52 100644
--- a/drivers/pps/clients/Kconfig
+++ b/drivers/pps/clients/Kconfig
@@ -2,12 +2,12 @@
 # LinuxPPS clients configuration
 #
 
+if PPS
+
 comment "PPS clients support"
-	depends on PPS
 
 config PPS_CLIENT_KTIMER
 	tristate "Kernel timer client (Testing client, use for debug)"
-	depends on PPS && EXPERIMENTAL
 	help
 	  If you say yes here you get support for a PPS debugging client
 	  which uses a kernel timer to generate the PPS signal.
@@ -15,29 +15,42 @@ config PPS_CLIENT_KTIMER
 	  This driver can also be built as a module.  If so, the module
 	  will be called ktimer.o.
 
+comment "UART serial support (forced off)"
+	depends on SERIAL_CORE && ( PPS = m && SERIAL_CORE = y )
+
 config PPS_CLIENT_UART
 	bool "UART serial support"
-	depends on PPS && SERIAL_CORE && \
-			! ( PPS = m && SERIAL_CORE = y ) && EXPERIMENTAL
+	depends on SERIAL_CORE && ! ( PPS = m && SERIAL_CORE = y )
+
+comment "8250 serial support (forced off)"
+	depends on PPS_CLIENT_UART && SERIAL_8250 && \
+			( PPS = m && SERIAL_8250 = y )
 
 config PPS_CLIENT_UART_8250
 	bool "8250 serial support"
 	depends on PPS_CLIENT_UART && SERIAL_8250 && \
-			! ( PPS = m && SERIAL_8250 = y ) && EXPERIMENTAL
+			! ( PPS = m && SERIAL_8250 = y )
 	help
 	  If you say yes here you get support for a PPS source connected
 	  with the CD (Carrier Detect) pin of your 8250 serial line chip.
 
+comment "Parallel printer support (forced off)"
+	depends on PRINTER && ( PPS = m && PRINTER = y )
+
 config PPS_CLIENT_LP
 	bool "Parallel printer support"
-	depends on PPS && PRINTER && \
-                       ! ( PPS = m && PRINTER = y ) && EXPERIMENTAL
+	depends on PRINTER && ! ( PPS = m && PRINTER = y )
+
+comment "Parport PC support (forced off)"
+	depends on PPS_CLIENT_LP && PARPORT_PC && \
+			( PPS = m && PARPORT_PC = y )
 
 config PPS_CLIENT_LP_PARPORT_PC
 	bool "Parport PC support"
 	depends on PPS_CLIENT_LP && PARPORT_PC && \
-                       ! ( PPS = m && PARPORT_PC = y ) && EXPERIMENTAL
+                       ! ( PPS = m && PARPORT_PC = y )
 	help
 	  If you say yes here you get support for a PPS source connected
 	  with the interrupt pin of your PC parallel port.
 
+endif