[LinuxPPS] compile fail with latest git pull

[Rodolfo Giometti]

On Mon, Feb 19, 2007 at 09:11:42AM -0800, gnu not unix wrote:
> 
> Hi Folks--I just did a git pull of linuxpps and it failed compile:
> 
>   CC [M]  drivers/char/mwave/mwavedd.o
> In file included from include/linux/serial_8250.h:14,
>                  from drivers/char/mwave/mwavedd.c:60:
> include/linux/serial_core.h: In function 'uart_handle_dcd_change':
> include/linux/serial_core.h:476: error: 
> 		'UART_MSR_DCD' undeclared (first use in this function)

Try this patch:

diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index c45a140..ea987af 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -473,7 +473,7 @@ uart_handle_dcd_change(struct uart_port *port, unsigned int  
 #ifdef CONFIG_PPS
        if ((port->flags & UPF_HARDPPS_CD) && status) {
-               if (status & UART_MSR_DCD) {
+               if (status) {
                        pps_event(up->port.pps_source, PPS_CAPTUREASSERT, port);                        dbg("serial8250: PPS assert event at %lu on source #%d",                                jiffies, up->port.pps_source);


The function uart_handle_dcd_change is called as:

   uart_handle_dcd_change(&up->port, status & UART_MSR_DCD);

so checking again the UART_MSR_DCD flag is unneeded.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127