[LinuxPPS] Re: [Bug 610] Generic NMEA GPS Receiver driver w/ PPS expects PPS after NMEA data

[Rodolfo Giometti]

On Mon, Oct 29, 2007 at 12:24:21PM +0100, Udo van den Heuvel wrote:
> 
> > In your solution if the alternate device is a valid char device but
> > not a PPS source you return error without trying the main
> > device. 
> 
> Not true. I retry the stored fd for NEMA data for PPS.

I see...

> > Instead, NTPD folks asked to you to check first the alternate
> > device for a PPS source and then fall back to the main device.
> 
> I do.
> I am at work now, so if I am mistaken please clarify.

No, you was right... reading carefully your patch it seem ok, even if
it's quite "hard" to read and the code is duplicated for the main
device (twice time_pps_create() for the main device). Maybe you can
transform it as I suggested... :P

However good job! I hope NTPD folks put it into main line.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127