[LinuxPPS] [PATCH]

[Rodolfo Giometti]

On Fri, Feb 01, 2008 at 10:30:58PM +1100, Cirilo Bernardo wrote:
> 
> How do I get a comment and "submitted by" entry into the diff?  I used:
> git diff origin master > the_patch
> I noticed that there was no way to identify who sent the patch etc,
> but I am unfamiliar with git and am having trouble finding out how to
> get it to do what I want.

You should commit the code into your repository by using the "-s"
options then use the git-format-patch to get a patch (or more). May
may wish setting also:

   GIT_AUTHOR_NAME
   GIT_COMMITTER_NAME
   GIT_COMMITTER_EMAIL
   GIT_AUTHOR_EMAIL

into your environment, or just use the command git-config to setup
your ~/.gitconfig file.

> Will the build system automatically set 'm' if this driver depends on
> pps_core and pps_core is built as a module?

Yes, use the keyword "depends on".

> > Set it to -1 and allow 0 as valid IRQ number.
> 
> OK - so I use -1 as the invalid value, but if the user specifies '0' I
> still need to bail out because 0 means "softirq" and this is not a
> dependable timer -- did I get that right?

Uh? Where did you find such info? I don't think so... :-o

> OK, I'll work through this - but I'll probably be slow since I have so
> much other work.  I never complain about paranoia - I build reliable

Don't worry, we are not into a hurry.

> unattended field instruments so paranoia is a virtue - that's probably
> also why I have so little time to do anything other than work -
> between documentation, testing, debugging there is no time left for
> anything else.

:)

>  With regards to static module variables - once upon a time they were
> encouraged to reduce "namespace pollution".  Does the current build
> system assure that variables are only visible within the module unless
> exported?  If that is the case I will remove all statics.

Yes. Also static variables doesn't allow several instances of the
driver.

>  The other driver I have needs some cleaning up and rethinking some
> things. The problem with the GPS I have (Trimble LassenSQ) is that the
> device generates an undisciplined PPS signal when there is no
> satellite lock and the manufacturer does not specify a tolerance.
> Obviously using such a signal is not good for an NTP reference clock
> and in my situation NTP will have no basis for deciding which clock is
> defective (system or GPS).  So my other driver is actually a fairly
> specialized GPS driver but it also interfaces to LinuxPPS; the PPS is
> only delivered to pps_core if there is a satellite lock and this way
> NTP is immediately aware that the problem is with the GPS.  I guess
> such a driver is better placed elsewhere since PPS is only a minor
> function of the driver - any comments on that?

Can you please explain better the problem? How can you decide when the
PPS is good or not?

I think that the PPS signal should be reported anyway to the system
but NTPD should decide (according to the GPS data) when it should use
it or not.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127