[LinuxPPS] 12 Jul 21:33 - cifs: fix inode leak in cifs_get_inode_info_unix

[linuxpps: Jeff Layton <>]

cifs: fix inode leak in cifs_get_inode_info_unix  
  
Try this:  
  
mount a share with unix extensions  
create a file on it  
umount the share  
  
You'll get the following message in the ring buffer:  
  
VFS: Busy inodes after unmount of cifs. Self-destruct in 5 seconds. Have a  
nice day...  
  
...the problem is that cifs_get_inode_info_unix is creating and hashing  
a new inode even when it's going to return error anyway. The first  
lookup when creating a file returns an error so we end up leaking this  
inode before we do the actual create. This appears to be a regression  
caused by commit 0e4bbde94fdc33f5b3d793166b21bf768ca3e098.  
  
The following patch seems to fix it for me, and fixes a minor  
formatting nit as well.  
  
Signed-off-by: Jeff Layton   
Acked-by: Steven French   
Signed-off-by: Andrew Morton   
Signed-off-by: Linus Torvalds   
  
fs/cifs/inode.c

URL: http://gitweb.enneenne.com/?p=linuxpps;a=commit;h=e911d0cc877ff027d5bd09fc33148ab76f0fdf0e