[LinuxPPS] ntp-dev-4.2.5p237-RC does sync with PPS for me

[Rodolfo Giometti]

On Tue, Oct 27, 2009 at 04:08:32PM +0100, Udo van den Heuvel wrote:
> On 2009-10-27 05:33, William S. Brasher wrote:
> >> Hopefully, this will be fixed in the next iteration of the
> >> kernel patch.
> >> -- 
> >>                                         Reg.Clemens
> >>                                         reg at dwf.com
> >>
> > 
> > Sounds reasonable, and should be a good place to look for problems.
> 
> Is Rodolfo aware of this issue?
> Does he have a fix?

Try this patch:

diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c
index 35a0b19..2d414e2 100644
--- a/drivers/pps/kapi.c
+++ b/drivers/pps/kapi.c
@@ -271,6 +271,7 @@ void pps_event(int source, struct pps_ktime *ts,
int event, 
 {
        struct pps_device *pps;
        unsigned long flags;
+       int captured = 0;
 
        if ((event & (PPS_CAPTUREASSERT | PPS_CAPTURECLEAR)) == 0) {
                printk(KERN_ERR "pps: unknown event (%x) for source
		%d\n",
@@ -293,7 +294,8 @@ void pps_event(int source, struct pps_ktime *ts,
int event, 
 
        /* Check the event */
        pps->current_mode = pps->params.mode;
-       if (event & PPS_CAPTUREASSERT) {
+       if ((event & PPS_CAPTUREASSERT) &
+                       (pps->params.mode & PPS_CAPTUREASSERT)) {
                /* We have to add an offset? */
                if (pps->params.mode & PPS_OFFSETASSERT)
                        pps_add_offset(ts,
			&pps->params.assert_off_tu);
@@ -303,8 +305,11 @@ void pps_event(int source, struct pps_ktime *ts,
int event,
                pps->assert_sequence++;
                pr_debug("capture assert seq #%u for source %d\n",
                        pps->assert_sequence, source);
+
+               captured = ~0;
        }
-       if (event & PPS_CAPTURECLEAR) {
+       if ((event & PPS_CAPTURECLEAR) &
+                       (pps->params.mode & PPS_CAPTURECLEAR)) {
                /* We have to add an offset? */
                if (pps->params.mode & PPS_OFFSETCLEAR)
                        pps_add_offset(ts, &pps->params.clear_off_tu);
@@ -314,12 +319,17 @@ void pps_event(int source, struct pps_ktime *ts,
int event
                pps->clear_sequence++;
                pr_debug("capture clear seq #%u for source %d\n",
                        pps->clear_sequence, source);
+
+               captured = ~0;
        }
 
-       pps->go = ~0;
-       wake_up_interruptible(&pps->queue);
+       /* Wake up iif captured somthing */
+       if (captured) {
+               pps->go = ~0;
+               wake_up_interruptible(&pps->queue);
 
-       kill_fasync(&pps->async_queue, SIGIO, POLL_IN);
+               kill_fasync(&pps->async_queue, SIGIO, POLL_IN);
+       }
 
        spin_unlock_irqrestore(&pps->lock, flags);
 
Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti at enneenne.com
Linux Device Driver                          giometti at linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it