[LinuxPPS] ntp-dev-4.2.5p237-RC does sync with PPS for me

[Rodolfo Giometti]

On Wed, Oct 28, 2009 at 08:54:59AM -0500, William S. Brasher wrote:
> On Wed, 28 Oct 2009, Rodolfo Giometti wrote:
> 
> > 
> > However a better implementation of the above setting should be:
> > 
> > diff --git a/Documentation/pps/ppstest.c b/Documentation/pps/ppstest.c
> > index d911bf6..30c8f6d 100644
> > --- a/Documentation/pps/ppstest.c
> > +++ b/Documentation/pps/ppstest.c
> > @@ -55,6 +55,7 @@ int find_source(char *path, pps_handle_t *handle,
> > int *avail_m
> >         params.assert_offset.tv_sec = 0;
> >         params.assert_offset.tv_nsec = 675;
> >         params.mode |= PPS_CAPTUREASSERT | PPS_OFFSETASSERT;
> > +       params.mode &= ~(PPS_CAPTURECLEAR | PPS_OFFSETCLEAR);
> >         ret = time_pps_setparams(*handle, &params);
> >         if (ret < 0) {
> >                 fprintf(stderr, "cannot set parameters (%m)\n");
> > 
> > Ciao,
> > 
> > Rodolfo
> > 
> > -- 
> > 
> > GNU/Linux Solutions                  e-mail: giometti at enneenne.com
> > Linux Device Driver                          giometti at linux.it
> > Embedded Systems                     phone:  +39 349 2432127
> > UNIX programming                     skype:  rodolfo.giometti
> > Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
> > 
> > 
> 
> 
> And the results are:
> 
> source 0 - assert 1256737706.999560770, sequence: 2930 - clear  1256734786.998287980, sequence: 10
> source 0 - assert 1256737707.999561031, sequence: 2931 - clear  1256734786.998287980, sequence: 10
> source 0 - assert 1256737708.999560666, sequence: 2932 - clear  1256734786.998287980, sequence: 10
> source 0 - assert 1256737709.999560329, sequence: 2933 - clear  1256734786.998287980, sequence: 10

Ok, this looks good to me. :)

So the issue about wrong assert/clear events reporting can be
considered fixed?

If so I'll report the patch to LinuxPPS repository and LKML adding:

   Tested-by: William S. Brasher <billb958 at door.net>
   Tested-by: Reg Clemens <clemens at dwf.com?

ok?

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti at enneenne.com
Linux Device Driver                          giometti at linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it