[LinuxPPS] Any Updates on that issue [PATCHv3 12/16] ntp: add hardpps implementation

[Udo van den Heuvel]

On 2010-10-08 14:48, Udo van den Heuvel wrote:
> Error in the patch?

Yes.
I put printk's in ntp.c:

static inline void pps_dec_valid(void)
{
        if (pps_valid > 0)
                { pps_valid--; printk(KERN_NOTICE "Clock: valid: %d\n",
pps_valid); }
        else {
                time_status &= ~(STA_PPSSIGNAL | STA_PPSJITTER |
                                 STA_PPSWANDER | STA_PPSERROR);
                pps_clear();
                printk(KERN_NOTICE "Clock: pps_valid is 0\n"); /*Udo */
        }
}


and also in hardpps() there.

ppsvalid remains 0. hardpps() is not run.
Isn't flag3 set to 1 enough?


Udo